Re: The Mods, Muling and Utilities Thread (new ATMA/GoMule thread)
New GoMule Release!
Welcome to R0.21.
As usual, some early bugs may come to light after the first few days of the release. Please be patient while these are dealt with. If you find one, please report it here! - Thanks.
To update: Download the new release, at
https://sourceforge.net/project/showfiles.php?group_id=194865, extract it and put your "projects" folder in the new GoMule folder. This should preserve your settings, clipboard and GoMule bank.
Bonus: - Documentation is now available with the download at:
https://sourceforge.net/project/showfiles.php?group_id=194865
(It's the PDF file). No complaints about spelling, my checker is broken. Stupid Kile.
Finally, I can shout "RTFM" rather than explain things :alright:
Basic Changelog:
Fixes
In the stats screen, lightning and cold resistance are switched. (Minor nitpick, poison is spelled wrong.) FIXED
MF total on the character stats screen doesn't always add up properly (e.g. when equipped with a Skulders) FIXED
item_tohitpercent_perlevel fixed (Thanks Helx). FIXED
Dump has no line breaks! - Bug in font too, needs Monospace. FIXED.
On weapon IAS will not be added. It's a pain in the ***, so quit being so lazy! Just count it. GoMule does the hard bit with tot IAS. FIXED
Can now select and OPEN multiple D2S/D2X using old open method. FIXED
Cells in stashes now show up as black when selected so you can see when you're multiple selecting! Happy days. FIXED
Stash tickbox for eth items so you can filter them. FIXED
BROKEN - new stash. Due to multichoose probably. FIXED
BUG switching weapons keeps adding to stats - FIXED
Backups now .org instead of .d2s to fix flavie related issues. FIXED
PErsonalised items not showing personalised name. FIXED (Could have sworn that was already done..).
Documentation - Done.
Forgot to run skills through tbl files - FIXED.
ASSASIN is spelt ASSASSIN! Fixed. How come no one noticed that before the tbl errors came up?
Features
New filter on stashes (read the manual for more info!)
Extended item information available for some items (read the manual for more info!)
Personal notes from this patch (the real changelog.) (I hope the rude word filter is still working...)
Code:
FIXED:
In the stats screen, lightning and cold resistance are switched. (Minor nitpick, poison is spelled wrong.) FIXED
MF total on the character stats screen doesn't always add up properly (e.g. when equipped with a Skulders) FIXED
item_tohitpercent_perlevel fixed (Thanks Helx). FIXED
Dump has no line breaks! - Bug in font too, needs Monospace. FIXED.
On weapon IAS will not be added. It's a pain in the ***, so quit being so lazy! Just count it. GoMule does the hard bit with tot IAS. FIXED
Can now select and OPEN multiple D2S/D2X using old open method. FIXED
Cells in stashes now show up as black when selected so you can see when you're multiple selecting! Happy days. FIXED
Stash tickbox for eth items so you can filter them. FIXED
BROKEN - new stash. Due to multichoose probably. FIXED
BUG switching weapons keeps adding to stats - FIXED
Backups now .org instead of .d2s to fix flavie related issues. FIXED
PErsonalised items not showing personalised name. FIXED (Could have sworn that was already done..).
Documentation - Done.
Forgot to run skills through tbl files - FIXED.
ASSASIN is spelt ASSASSIN! Fixed. How come no one noticed that before the tbl errors came up?
Add chars/Stashes to project function
- Same as opening multiple but doesn't actually open them, just adds em to the list (prevents mem overflow if opening too much!).
- Access through new button with new icon! I'm also very excited. I made it myself.
RunewordiD now correctly read from the D2S file. For some reason it's 12 bits + 4 bits rather than the 16 bits it was first put down as. The 4 bits appear to be useless (5?). - Further investigation shows that this runeword_id is an ID, but there doesn't seem to be an index to it. Ho hum....
Rare names for pre/suf ixxes (Under EXTENDED ITEM INFO on RIGHT CLICK)
- So you can see what you actually have. RTB's idea I believe.
A toggleable second window which shows the min/max stats of the item you are viewing <-Not amazing. But hey, gimmie feedback. Also RTB's idea? I can't remember. (Under EXTENDED ITEM INFO on RIGHT CLICK)
- Elemental damage is fubar'd. It's complicated, but for now it just shows "xxx damage" where xxx is the type of damage it should be doing, rather than just having an empty space.
-Add runewords - Done PROBLEM - Rune values not added on top of RW bonuses. But they're static anyway, so w/e. See below for bug.
- ETH DEF? I think it adds it. It might not? I can't see that it adds it in the code, but it seems to add it in the end somehow. I should use more comments.
- Sockets kept showing up as incorrect numbers (3 was a recurring theme). Items now have "some" sockets.
- Now Stats are in the correct order.
- Bug with charges on HOTO. Possibly sort function? props same, ival diff. Fixed.
- Weapon damage not displaying - properties.txt has 2 columns for damage +, only reading one. Fixed.
- OSkills still not working - probably 3 skills instead of 2. Fixed.
- RTB> oh you're not adding up dmg-undead from properties and from being blunt yet - I probably am. And I don't care about blunt items.
- <RTB> The Vile Husk bugged up bad: FIXED Stupid blizzard.
- <RTB> bla bla should look like this [x - x] bla bla: Maybe next release. Need to overhaul the properties class entirely first now.
GEM properties issue - Combined resistances? Yeah, combineResists method causing problems. I wish I had documented this method. COMMENT MORE YOU FOOL.
- Further investigation shows this is in the combineProps method. Or not. In fact, I have no idea what's going on. Combineprops - 15, combine resists - combine props - 65
- Removed all code, note lines with WARN. Bug still exists. HOW!!!
- Removing some more code (that doesn't read as if it should affect anything) removes the +50 res from the rw. But the +15 is preserved from the rune.
- Rather than storing 1337 on rwprop it's doing it on gemprop? Werid. It's moving to iprop, which is correct, but also moving to igem as well. I think?
- **** it _ MARK AS FUTUREFIX, Document fix as hacky but works, Line 2600 ish. Hm, Fix doesn't work either. Marked as bug for another day. It's not important.
- Mark perfect runewords as not including rune stats as feature?
Filter button - Allows you to filter by any stat.
- Just click filter, enter what you're looking for (even partial, eg "finding magic items" "10" and it'll return.
- Max means max, min means min. Should be obvious.
- Too lazy to work out the prop box. No. I won't.
Chance to block? How did we miss that beta testers?
- Block chance read out of Armor.txt is incorrect? 22 for SS, doesn't seem to be in any way related. How is it split up for each class? Hardcoded?
- <RTB> Base values are in charstats.txt
<RTB> values in armor.txt add to that.
- Needs to be character field not item field...well, arm.txt -> item, field in char can read the rest.
- it would have been ****ING AMAZING to know about charstats.txt before I hardcoded all the stats stuff ARGH.
- Added: ON ITEM as actual ITEM BLOCK. DOES NOT INCLUDE CHAR BLOCK (so it's lower than you think it is!).
- ON CHAR as actual BLOCK, that's the whole formula, takes dex etc into account.
- type issues? Ear related. FIXED.
Font issues - MS Windows has larger monospace so it's cut all the stats off the bottom! **** YOU MICROSOFT.
- Solution - Extract linux mono font and supply in resources? May work.
- FIXED. Makes mine look worse though (grumble grumble). Stupud windows users
Slow closing - What the hell, characters take ages to close. ********. Stashes too
- bugger bugger bugger. Could be due to multichoose?
- Undocumented forced garbage collection which I added was causing slowdown on D2FileManager. D2ViewChar and D2ViewStash are still slow though! Isolated to changes in just those 2 java files.
- They're pretty big files. Ponder ponder ponder.
- Oh ho...I added manual GC's to these as well! AWESOME. Conclusion: I'm a dumbass. And that was some sexy debugging.
- System.gc(); now exists in removeFromOpenWindows in D2FileManager.java. Nope, still slow. Ah ********. It didn't matter too much.
- FIXED - NO MORE FORCED GC. LEARN TO CODE PROPERLY.
NEGATIVE XP - Binary shows correct. Reading 33 instead of 32 bits returns SAME value! Odd. Incapable of doing 32? Reading 31 returns correct value. Try reading in 2 blocks of 16?
- Works until I try to put it into an int. IF THIS IS A ****ING OVERFLOW I WILL KILL SOMEONE.
- ARGHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHh.
- **** this, I'm going to bed.
- FIXED! FINALLY :D :D :D
IMP DAMAGE: private void cleanUpProperties() {
- Ensure removed from iruneword properties too.
- Steel display issues.
- FIXED.
To all those who made suggestions - Thanks

I hope what you wanted fixed/implemented is now fixed/implemented. Without your ideas and bug finding, GoMule wouldn't be the (horribly memory intensive

) program it is now.
Enjoy.

arty: